Skip to content

Started annotating connections.pyi#15395

Draft
Spider84pr wants to merge 2 commits intopython:mainfrom
Spider84pr:pysql
Draft

Started annotating connections.pyi#15395
Spider84pr wants to merge 2 commits intopython:mainfrom
Spider84pr:pysql

Conversation

@Spider84pr
Copy link
Contributor

@Spider84pr Spider84pr commented Feb 8, 2026

Starting with a small commit - I want to look how the test will run.

@github-actions

This comment has been minimized.

Sign in to view
@Spider84pr Spider84pr marked this pull request as draft February 8, 2026 23:12
@Spider84pr
Copy link
Contributor Author

Spider84pr commented Feb 8, 2026 •
edited
Loading

I have marked this PR as draft - I will make more commits in next several days. If such thing is forbidden - please write - I will close.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau
Copy link
Collaborator

srittau commented Feb 9, 2026

I have marked this PR as draft - I will make more commits in next several days. If such thing is forbidden - please write - I will close.

That's perfectly fine, and a good hint for us maintainers to ignore the PR for now. Thanks!

@Spider84pr
Copy link
Contributor Author

Spider84pr commented Mar 10, 2026

Sorry I was busy and cannot start work.
Can you give me a hint and tell - if function def dump_packet(data) requiring annotations?
It missing in currant release

@srittau
Copy link
Collaborator

srittau commented Mar 16, 2026

Sorry I was busy and cannot start work. Can you give me a hint and tell - if function def dump_packet(data) requiring annotations? It missing in currant release

@Spider84pr Seeing that it's only imported from .protocol in .connections, I would recommend removing it from connections.pyi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Spider84pr @srittau